Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 610433003: Eliminate global argument passing list. (Closed)

Created:
6 years, 2 months ago by regis
Modified:
6 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Eliminate global argument passing list. Refactor _mulAdd to perform carry propagation and update intrinsic on ia32. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40816

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -85 lines) Patch
M runtime/lib/bigint.dart View 1 2 9 chunks +34 lines, -51 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 2 5 chunks +48 lines, -33 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
regis
This cl builds on top of reverted r40623. So it cannot be submitted before r40623 ...
6 years, 2 months ago (2014-09-25 21:51:13 UTC) #2
srdjan
lgtm https://codereview.chromium.org/610433003/diff/1/runtime/lib/bigint.dart File runtime/lib/bigint.dart (right): https://codereview.chromium.org/610433003/diff/1/runtime/lib/bigint.dart#newcode1326 runtime/lib/bigint.dart:1326: var _u0digit; I would give all instance fields ...
6 years, 2 months ago (2014-09-25 22:19:28 UTC) #3
regis
Thanks! https://codereview.chromium.org/610433003/diff/1/runtime/lib/bigint.dart File runtime/lib/bigint.dart (right): https://codereview.chromium.org/610433003/diff/1/runtime/lib/bigint.dart#newcode1326 runtime/lib/bigint.dart:1326: var _u0digit; On 2014/09/25 22:19:27, srdjan wrote: > ...
6 years, 2 months ago (2014-09-25 22:26:37 UTC) #4
regis
6 years, 2 months ago (2014-09-30 16:47:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r40816 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698