Support static field access in analyzer2dart.

Support static field access in analyzer2dart.

Static field declaration is not currently supported in the CPS IR.

I've injected the SemanticVisitor as a common superclass of the TypeShakerVisitor and CpsGeneratingVisitor to reuse the classifyX handling.

R=paulberry@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40761

[Johnni Winther, 2014-09-26 11:41:35]

johnniwinther@google.com changed reviewers:
+ paulberry@google.com, sigurdm@google.com

[Johnni Winther, 2014-09-26 11:41:35]

paulberry@: PTAL at the analyzer2dart implementation.
sigurdm@: PTAL at the modifications to dart2js.

[Paul Berry, 2014-09-26 16:42:39]

lgtm

https://codereview.chromium.org/609783002/diff/1/pkg/analyzer2dart/test/tree_...
File pkg/analyzer2dart/test/tree_shaker_test.dart (right):

https://codereview.chromium.org/609783002/diff/1/pkg/analyzer2dart/test/tree_...
pkg/analyzer2dart/test/tree_shaker_test.dart:54: });
We should probably also test that this drags a "call" selector into the world. 
I think we could accomplish that with something like:

var helper = new TreeshakerTestHelper('''
class A {
  void call() {}
  void baz() {}
}
main() {
  new A();
  return foo;
}
var foo;
var bar;
''');
helper.assertHasFunction('main');
helper.assertHasVariable('foo');
helper.assertNoVariable('bar');
helper.assertHasInstantiatedClass('A');
helper.assertHasMethod('A.call');
helper.assertNoMethod('A.baz');

[sigurdm, 2014-09-29 08:59:42]

LGTM

https://codereview.chromium.org/609783002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart
(right):

https://codereview.chromium.org/609783002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:1473:
selector.kind == SelectorKind.SETTER);
Not your code, but it seems we should here only check for getters.

[Johnni Winther, 2014-09-29 10:39:07]

Committed patchset #2 (id:20001) manually as 40761 (presubmit successful).

[Johnni Winther, 2014-09-29 13:07:25]

https://codereview.chromium.org/609783002/diff/1/pkg/analyzer2dart/test/tree_...
File pkg/analyzer2dart/test/tree_shaker_test.dart (right):

https://codereview.chromium.org/609783002/diff/1/pkg/analyzer2dart/test/tree_...
pkg/analyzer2dart/test/tree_shaker_test.dart:54: });
On 2014/09/26 16:42:39, Paul Berry wrote:
> We should probably also test that this drags a "call" selector into the world.

> I think we could accomplish that with something like:
> 
> var helper = new TreeshakerTestHelper('''
> class A {
>   void call() {}
>   void baz() {}
> }
> main() {
>   new A();
>   return foo;
> }
> var foo;
> var bar;
> ''');
> helper.assertHasFunction('main');
> helper.assertHasVariable('foo');
> helper.assertNoVariable('bar');
> helper.assertHasInstantiatedClass('A');
> helper.assertHasMethod('A.call');
> helper.assertNoMethod('A.baz');

Added with 'foo()' instead of 'return foo'.

https://codereview.chromium.org/609783002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart
(right):

https://codereview.chromium.org/609783002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:1473:
selector.kind == SelectorKind.SETTER);
On 2014/09/29 08:59:42, sigurdm wrote:
> Not your code, but it seems we should here only check for getters.

Added a TODO.