Address MSVS 2013 warning C4146: unary minus operator applied to unsigned type, result still unsign…

Address MSVS 2013 warning C4146: unary minus operator applied to unsigned type, result still unsigned

R=koda@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40697

[rmacnak, 2014-09-25 21:23:32]

rmacnak@google.com changed reviewers:
+ koda@google.com

[koda, 2014-09-25 21:31:28]

https://codereview.chromium.org/609563002/diff/1/runtime/vm/object_set.h
File runtime/vm/object_set.h (right):

https://codereview.chromium.org/609563002/diff/1/runtime/vm/object_set.h#newc...
runtime/vm/object_set.h:34: data_ = &allocation_[0 - ((start >> kWordSizeLog2) /
kBitsPerWord)];
Consider creating a local intptr_t for the expression, and then negate it. It
may not be obvious to the reader that this subtraction produces a signed result
(even if it satisfies the compiler).

[rmacnak, 2014-09-25 22:06:22]

On 2014/09/25 21:31:28, koda wrote:
> https://codereview.chromium.org/609563002/diff/1/runtime/vm/object_set.h
> File runtime/vm/object_set.h (right):
> 
>
https://codereview.chromium.org/609563002/diff/1/runtime/vm/object_set.h#newc...
> runtime/vm/object_set.h:34: data_ = &allocation_[0 - ((start >> kWordSizeLog2)
/
> kBitsPerWord)];
> Consider creating a local intptr_t for the expression, and then negate it. It
> may not be obvious to the reader that this subtraction produces a signed
result
> (even if it satisfies the compiler).

PTAL - Not trilled about the name.

[koda, 2014-09-25 22:08:23]

LGTM if you use it below. The name is better than no name :)

https://codereview.chromium.org/609563002/diff/20001/runtime/vm/object_set.h
File runtime/vm/object_set.h (right):

https://codereview.chromium.org/609563002/diff/20001/runtime/vm/object_set.h#...
runtime/vm/object_set.h:36: ASSERT(allocation_ == &data_[(start >>
kWordSizeLog2) / kBitsPerWord]);
Please make it a "const intptr_t" and then use it here too.

[rmacnak, 2014-09-25 22:15:23]

https://codereview.chromium.org/609563002/diff/20001/runtime/vm/object_set.h
File runtime/vm/object_set.h (right):

https://codereview.chromium.org/609563002/diff/20001/runtime/vm/object_set.h#...
runtime/vm/object_set.h:36: ASSERT(allocation_ == &data_[(start >>
kWordSizeLog2) / kBitsPerWord]);
On 2014/09/25 22:08:23, koda wrote:
> Please make it a "const intptr_t" and then use it here too.

Done.

[rmacnak, 2014-09-25 22:15:51]

Committed patchset #3 (id:40001) manually as 40697 (presubmit successful).