Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 60943003: Fix scoping of catch clause variables (Closed)

Created:
7 years, 1 month ago by hausner
Modified:
7 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)
Visibility:
Public.

Description

Fix scoping of catch clause variables Fix recent regression in try-catch and fix scoping of exception object and stack trace variable. Add test to ensure shadowing of these variables is possible. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=29947

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M runtime/vm/parser.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M tests/language/try_catch_test.dart View 1 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 1 month ago (2013-11-05 23:15:30 UTC) #1
regis
LGTM
7 years, 1 month ago (2013-11-05 23:22:26 UTC) #2
hausner
7 years, 1 month ago (2013-11-06 00:05:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29947 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698