Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 608873002: Multitest has a 'checked mode compile-time error' marker now. Use it to clean up the mirrors status… (Closed)

Created:
6 years, 2 months ago by rmacnak
Modified:
6 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Multitest has a 'checked mode compile-time error' marker now. Use it to clean up the mirrors status file a bit. BUG=http://dartbug.com/16351 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40799

Patch Set 1 #

Patch Set 2 : also mark analyzer as failing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M tests/lib/lib.status View 1 2 chunks +3 lines, -6 lines 0 comments Download
M tests/lib/mirrors/regress_16321_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
6 years, 2 months ago (2014-09-26 20:19:24 UTC) #2
regis
LGTM
6 years, 2 months ago (2014-09-26 21:20:05 UTC) #3
rmacnak
6 years, 2 months ago (2014-09-30 04:41:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698