Cleanup of code generation for StrictCompare.

Cleanup of code generation for StrictCompare.

The case of two constant operands does not occur unless certain optimizations
are turned off. It is not necessary to have a special handling in the code
generator for this case.

R=kmillikin@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30153

[Kevin Millikin (Google), 2013-11-11 12:09:42]

It definitely needs a comment, otherwise LGTM.

https://codereview.chromium.org/60883003/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/60883003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:4437: locs->set_in(1,
locs->in(0).IsConstant()
This is cryptic without a comment.  Try:

"We rely on at least one input argument in a register, so if the first is a
constant ask for the second in a register."

Same comment on all platforms.

[Florian Schneider, 2013-11-11 12:29:28]

https://codereview.chromium.org/60883003/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/60883003/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_arm.cc:4437: locs->set_in(1,
locs->in(0).IsConstant()
On 2013/11/11 12:09:42, kmillikin wrote:
> This is cryptic without a comment.  Try:
> 
> "We rely on at least one input argument in a register, so if the first is a
> constant ask for the second in a register."
> 
> Same comment on all platforms.

Done.

[Florian Schneider, 2013-11-11 13:01:59]

Committed patchset #2 manually as r30153 (presubmit successful).