Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 608693004: Add tools script to update homebrew, the MacOS SDK updating solution. (Closed)

Created:
6 years, 2 months ago by Bill Hesse
Modified:
6 years, 2 months ago
Reviewers:
ricow1, Søren Gjesse
CC:
reviews_dartlang.org, ricow1, Søren Gjesse, sethladd
Visibility:
Public.

Description

Add tools script to update homebrew, the MacOS SDK updating solution. BUG=dartbug.com/20210 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=40801

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change script to write static_info and dev_info files, include them in the formulas. #

Patch Set 3 : Rewrite script to overwrite data files in repo, instead of modifying formula files. #

Total comments: 3

Patch Set 4 : Address comments, move generated files to subdir. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -0 lines) Patch
A tools/apps/update_homebrew/bin/ssh_with_key View 1 chunk +2 lines, -0 lines 0 comments Download
A tools/apps/update_homebrew/bin/update_homebrew.dart View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download
A tools/apps/update_homebrew/pubspec.yaml View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bill Hesse
6 years, 2 months ago (2014-09-26 08:42:34 UTC) #2
Søren Gjesse
dbc. https://codereview.chromium.org/608693004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart File tools/apps/update_homebrew/bin/update_homebrew.dart (right): https://codereview.chromium.org/608693004/diff/1/tools/apps/update_homebrew/bin/update_homebrew.dart#newcode54 tools/apps/update_homebrew/bin/update_homebrew.dart:54: Future modifyHomebrewFormulas(String channel, int revision) { Wouldn't it ...
6 years, 2 months ago (2014-09-26 08:55:00 UTC) #4
Bill Hesse
PTAL. Updated to write out the data to two data files, rather than modifying the ...
6 years, 2 months ago (2014-09-29 14:18:12 UTC) #5
Søren Gjesse
lgtm https://codereview.chromium.org/608693004/diff/40001/tools/apps/update_homebrew/pubspec.yaml File tools/apps/update_homebrew/pubspec.yaml (right): https://codereview.chromium.org/608693004/diff/40001/tools/apps/update_homebrew/pubspec.yaml#newcode4 tools/apps/update_homebrew/pubspec.yaml:4: args: "0.12.0+2" Make it ">=0.12.0+2 <0.13.0" https://codereview.chromium.org/608693004/diff/40001/tools/apps/update_homebrew/pubspec.yaml#newcode5 tools/apps/update_homebrew/pubspec.yaml:5: ...
6 years, 2 months ago (2014-09-29 16:22:18 UTC) #6
Bill Hesse
Committed patchset #4 (id:60001) manually as 40801 (presubmit successful).
6 years, 2 months ago (2014-09-30 09:14:54 UTC) #7
ricow1
6 years, 2 months ago (2014-09-30 10:37:48 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698