Issue 608363003: Issue 19670. 'Create field' quick fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 608363003: Issue 19670. 'Create field' quick fix. (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 19670. 'Create field' quick fix. R=brianwilkerson@google.com, paulberry@google.com BUG= https://code.google.com/p/dart/issues/detail?id=19670 Committed: https://code.google.com/p/dart/source/detail?r=40782

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+237 lines, -17 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/fix.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	10 chunks	+131 lines, -17 lines	1 comment	Download
M	pkg/analysis_server/test/services/correction/fix_test.dart	View	1 chunk	+104 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 (id:1) manually as 40782 (presubmit successful).

6 years, 2 months ago (2014-09-29 19:45:39 UTC) #3

Paul Berry

6 years, 2 months ago (2014-09-29 20:08:00 UTC) #4

Message was sent while issue was closed.

lgtm once the following issue is resolved.

https://codereview.chromium.org/608363003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/608363003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:1354: return;
I don't understand why we want to return in this case.  It seems to me that if
the code is:

class A {
  foo() {
    print(x);
  }
}

we should still offer "create field x" as a fix, even though there is no
assignment ancestor.

Expand Messages | Collapse Messages