Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 60833003: Changed breaking image to discrepancy (2%) and made clock into collection. Repeating click on test… (Closed)

Created:
7 years, 1 month ago by ericarnold
Modified:
7 years, 1 month ago
Reviewers:
messick
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changed breaking image to discrepancy (2%) and made clock into collection. Repeating click on test item in browser. Added a wait for my setup and differentiated index.html from out/index.html BUG= R=messick@google.com Committed: https://code.google.com/p/dart/source/detail?r=29953

Patch Set 1 #

Patch Set 2 : Removed wait #

Patch Set 3 : removed old .project TRUNK setting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -127 lines) Patch
M .gitignore View 1 chunk +3 lines, -3 lines 0 comments Download
M editor/util/testing/mac/CodeLab.suite/Scripts/Step 0.script View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/util/testing/mac/CodeLab.suite/Scripts/Step 3.script View 1 chunk +2 lines, -0 lines 0 comments Download
M editor/util/testing/mac/DartEditor.suite/Images/Breaking.imageinfo View 1 chunk +38 lines, -17 lines 0 comments Download
D editor/util/testing/mac/DartEditor.suite/Images/clock title.imageinfo View 1 chunk +0 lines, -17 lines 0 comments Download
D editor/util/testing/mac/DartEditor.suite/Images/clock title.png View Binary file 0 comments Download
A editor/util/testing/mac/DartEditor.suite/Images/clock title/clock title.imageinfo View 1 chunk +36 lines, -0 lines 0 comments Download
A + editor/util/testing/mac/DartEditor.suite/Images/clock title/clock title.png View Binary file 0 comments Download
A editor/util/testing/mac/DartEditor.suite/Images/clock title/clock title 2.imageinfo View 1 chunk +33 lines, -0 lines 0 comments Download
A editor/util/testing/mac/DartEditor.suite/Images/clock title/clock title 2.tiff View Binary file 0 comments Download
M editor/util/testing/mac/Samples.suite/Images/check mark.imageinfo View 1 chunk +38 lines, -17 lines 0 comments Download
D editor/util/testing/mac/Samples.suite/Images/clock title.imageinfo View 1 chunk +0 lines, -17 lines 0 comments Download
D editor/util/testing/mac/Samples.suite/Images/clock title.png View Binary file 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/clock title/clock title.imageinfo View 1 chunk +36 lines, -0 lines 0 comments Download
A + editor/util/testing/mac/Samples.suite/Images/clock title/clock title.png View Binary file 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/clock title/clock title 2.imageinfo View 1 chunk +33 lines, -0 lines 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/clock title/clock title 2.tiff View Binary file 0 comments Download
D editor/util/testing/mac/Samples.suite/Images/solar title.imageinfo View 1 chunk +0 lines, -17 lines 0 comments Download
D editor/util/testing/mac/Samples.suite/Images/solar title.png View Binary file 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/solar title/solar title.imageinfo View 1 chunk +36 lines, -0 lines 0 comments Download
A + editor/util/testing/mac/Samples.suite/Images/solar title/solar title.png View Binary file 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/solar title/solar title 2.imageinfo View 1 chunk +33 lines, -0 lines 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/solar title/solar title 2.tiff View Binary file 0 comments Download
D editor/util/testing/mac/Samples.suite/Images/swipe title.imageinfo View 1 chunk +0 lines, -17 lines 0 comments Download
D editor/util/testing/mac/Samples.suite/Images/swipe title.png View Binary file 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/swipe title/swipe title.imageinfo View 1 chunk +36 lines, -0 lines 0 comments Download
A + editor/util/testing/mac/Samples.suite/Images/swipe title/swipe title.png View Binary file 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/swipe title/swipe title 2.imageinfo View 1 chunk +33 lines, -0 lines 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/swipe title/swipe title 2.tiff View Binary file 0 comments Download
D editor/util/testing/mac/Samples.suite/Images/todo title.imageinfo View 1 chunk +0 lines, -17 lines 0 comments Download
D editor/util/testing/mac/Samples.suite/Images/todo title.png View Binary file 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/todo title/todo title.imageinfo View 1 chunk +33 lines, -0 lines 0 comments Download
A editor/util/testing/mac/Samples.suite/Images/todo title/todo title.tiff View Binary file 0 comments Download
M editor/util/testing/mac/Samples.suite/Scripts/clock.script View 1 chunk +2 lines, -1 line 0 comments Download
M editor/util/testing/mac/Samples.suite/Scripts/swipe.script View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/testing/mac/Samples.suite/Scripts/todo.script View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
messick
lgtm Good progress!
7 years, 1 month ago (2013-11-06 01:19:42 UTC) #1
ericarnold
7 years, 1 month ago (2013-11-06 01:23:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 manually as r29953 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698