Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 607963002: Fix glob list on Windows. (Closed)

Created:
6 years, 2 months ago by Bob Nystrom
Modified:
6 years, 2 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix glob list on Windows. BUG=https://code.google.com/p/dart/issues/detail?id=21071 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=40732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M pkg/glob/lib/glob.dart View 2 chunks +2 lines, -9 lines 0 comments Download
M pkg/glob/lib/src/ast.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/glob/lib/src/list_tree.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/glob/lib/src/utils.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/glob/test/list_test.dart View 2 chunks +4 lines, -8 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Bob Nystrom
Both the tests and the code were wrong! :)
6 years, 2 months ago (2014-09-26 17:27:01 UTC) #2
nweiz
lgtm
6 years, 2 months ago (2014-09-26 19:27:21 UTC) #3
nweiz
On 2014/09/26 19:27:21, nweiz wrote: > lgtm Actually, be sure to bump the pubspec and ...
6 years, 2 months ago (2014-09-26 19:27:42 UTC) #4
Bob Nystrom
On 2014/09/26 19:27:42, nweiz wrote: > On 2014/09/26 19:27:21, nweiz wrote: > > lgtm > ...
6 years, 2 months ago (2014-09-26 19:47:07 UTC) #5
Bob Nystrom
6 years, 2 months ago (2014-09-26 19:47:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40732 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698