Issue 607813003: Use a separate request for 'Sort members' feature, not a refactoring.

Issue 607813003: Use a separate request for 'Sort members' feature, not a refactoring. (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Paul Berry, lukechurch, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use a separate request for 'Sort members' feature, not a refactoring. As requested in https://codereview.chromium.org/609653002/ R=brianwilkerson@google.com, lukechurch@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40713

Patch Set 1 #

Total comments: 2

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+252 lines, -65 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	4 chunks	+32 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	2 chunks	+133 lines, -34 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_test_methods.dart	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	2 chunks	+24 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	2 chunks	+23 lines, -10 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 (id:1) manually as 40713 (presubmit successful).

6 years, 2 months ago (2014-09-26 15:53:55 UTC) #3

Paul Berry

lgtm https://codereview.chromium.org/607813003/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/607813003/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode1292 pkg/analysis_server/tool/spec/spec_input.html:1292: </p> Do we need to include documentation of ...

6 years, 2 months ago (2014-09-26 16:23:53 UTC) #4

scheglov

6 years, 2 months ago (2014-09-26 16:44:43 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/607813003/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/607813003/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:1292: </p>
On 2014/09/26 16:23:53, Paul Berry wrote:
> Do we need to include documentation of what happens in the event of an error?
> (E.g. what happens if a file is specified that doesn't exist?  Can parse or
scan
> errors ever prevent the sort from succeeding?)

https://codereview.chromium.org/604333002

Expand Messages | Collapse Messages