Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 60733003: Version 0.8.10.6 (Closed)

Created:
7 years, 1 month ago by ricow1
Modified:
7 years, 1 month ago
Reviewers:
kasperl, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Version 0.8.10.6 svn merge -c 29893 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29898 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29903 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29912 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29914 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29922 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29924 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29925 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29926 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29928 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29930 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29931 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29932 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29935 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29936 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29938 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29939 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29940 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29942 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29943 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29945 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29948 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29950 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29951 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29952 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29955 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29958 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29959 https://dart.googlecode.com/svn/branches/bleeding_edge trunk svn merge -c 29961 https://dart.googlecode.com/svn/branches/bleeding_edge trunk R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=29962

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -218 lines) Patch
M dart/runtime/bin/dartutils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M dart/runtime/bin/dartutils.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M dart/runtime/bin/gen_snapshot.cc View 1 chunk +2 lines, -1 line 0 comments Download
M dart/runtime/bin/io_impl_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M dart/runtime/bin/main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M dart/runtime/bin/run_vm_tests.cc View 1 chunk +2 lines, -1 line 0 comments Download
M dart/runtime/include/dart_api.h View 2 chunks +3 lines, -1 line 0 comments Download
M dart/runtime/lib/math_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/vm/assembler_ia32.h View 4 chunks +10 lines, -9 lines 0 comments Download
M dart/runtime/vm/assembler_ia32.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M dart/runtime/vm/ast.cc View 3 chunks +15 lines, -2 lines 0 comments Download
M dart/runtime/vm/code_generator.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M dart/runtime/vm/dart.h View 1 chunk +2 lines, -1 line 0 comments Download
M dart/runtime/vm/dart.cc View 1 chunk +3 lines, -1 line 0 comments Download
M dart/runtime/vm/dart_api_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M dart/runtime/vm/flow_graph_type_propagator.cc View 3 chunks +12 lines, -18 lines 0 comments Download
M dart/runtime/vm/isolate.h View 6 chunks +13 lines, -0 lines 0 comments Download
M dart/runtime/vm/isolate.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M dart/runtime/vm/object.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M dart/runtime/vm/parser.cc View 5 chunks +36 lines, -49 lines 4 comments Download
A + dart/runtime/vm/random.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/runtime/vm/random.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M dart/runtime/vm/vm_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + dart/samples/dartiverse_search/readme.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/samples/google_maps/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/samples/google_maps/pubspec.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/samples/google_maps/test/google_maps_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/samples/google_maps/web/index.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + dart/samples/google_maps/web/index.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M dart/samples/samples.status View 1 chunk +2 lines, -0 lines 0 comments Download
M dart/sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +59 lines, -24 lines 0 comments Download
M dart/sdk/lib/html/dartium/html_dartium.dart View 4 chunks +59 lines, -24 lines 0 comments Download
M dart/tests/co19/co19-dart2dart.status View 2 chunks +8 lines, -1 line 0 comments Download
M dart/tests/co19/co19-runtime.status View 3 chunks +12 lines, -2 lines 0 comments Download
M dart/tests/compiler/dart2js/mirror_helper_unique_minification_test.dart View 1 chunk +5 lines, -1 line 0 comments Download
M dart/tests/compiler/dart2js/union_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/html/custom/created_callback_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/html/html.status View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/language/class_override_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/language.status View 2 chunks +0 lines, -13 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 2 chunks +0 lines, -14 lines 0 comments Download
M dart/tests/language/malformed_test.dart View 3 chunks +36 lines, -20 lines 0 comments Download
M dart/tests/standalone/io/skipping_dart2js_compilations_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tools/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M dart/tools/dom/docs/docs.json View 3 chunks +33 lines, -5 lines 0 comments Download
M dart/tools/dom/src/CanvasImageSource.dart View 1 chunk +30 lines, -19 lines 0 comments Download
M deps/dartium.deps/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
This does not include all the files, I left out new samples since they include ...
7 years, 1 month ago (2013-11-06 10:01:35 UTC) #1
ricow1
Ivan: I added comments on my additional changes after our conflict resolving(discovered while building). Just ...
7 years, 1 month ago (2013-11-06 10:05:18 UTC) #2
ricow1
actually +iposva
7 years, 1 month ago (2013-11-06 10:05:36 UTC) #3
kasperl
LGTM.
7 years, 1 month ago (2013-11-06 10:07:55 UTC) #4
ricow1
Committed patchset #1 manually as r29962 (presubmit successful).
7 years, 1 month ago (2013-11-06 10:19:16 UTC) #5
Ivan Posva
7 years, 1 month ago (2013-11-06 15:54:37 UTC) #6
Message was sent while issue was closed. 
parser.cc changes with comments LGTM -ip

https://codereview.chromium.org/60733003/diff/1/dart/runtime/vm/parser.cc
File dart/runtime/vm/parser.cc (right):

https://codereview.chromium.org/60733003/diff/1/dart/runtime/vm/parser.cc#new...
dart/runtime/vm/parser.cc:6941: if (!exception_param.type->IsInstantiated() &&
On 2013/11/06 10:05:18, ricow1 wrote:
> Ivan: I changed back to -> here, the merge changed this

✓

https://codereview.chromium.org/60733003/diff/1/dart/runtime/vm/parser.cc#new...
dart/runtime/vm/parser.cc:6969: *exception_param.type));
On 2013/11/06 10:05:18, ricow1 wrote:
> Ivan: I added * here to make us compile

✓

Powered by Google App Engine
This is Rietveld 408576698