Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 607153002: Support percent/permille formats with positive and negative variations (Closed)

Created:
6 years, 2 months ago by Alan Knight
Modified:
6 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[ak] Support percent/permille formats with positive and negative variations BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=40733

Patch Set 1 #

Patch Set 2 : Update CHANGELOG.md and bump package version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M pkg/intl/CHANGELOG.md View 1 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/intl/lib/src/intl/number_format.dart View 3 chunks +9 lines, -6 lines 0 comments Download
M pkg/intl/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/test/number_format_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
6 years, 2 months ago (2014-09-26 18:09:45 UTC) #2
Emily Fortuna
nice! lgtm
6 years, 2 months ago (2014-09-26 20:01:02 UTC) #3
Alan Knight
6 years, 2 months ago (2014-09-26 20:02:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40733 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698