Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 605853003: Stop suppressing generation of bindings with Promise. (Closed)

Created:
6 years, 2 months ago by rmacnak
Modified:
6 years, 2 months ago
Reviewers:
vsm, Leaf, terry
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41136

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Patch Set 6 : rebase #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+732 lines, -16 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 2 3 4 5 16 chunks +92 lines, -6 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 18 chunks +244 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 18 chunks +202 lines, -0 lines 0 comments Download
A tests/html/fontface_loaded_test.dart View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
A tests/html/storage_quota_test.dart View 1 2 3 4 1 chunk +37 lines, -0 lines 0 comments Download
M tools/dom/dom.json View 1 2 3 4 5 14 chunks +90 lines, -6 lines 0 comments Download
M tools/dom/idl/dart/dart.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 3 4 5 4 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
rmacnak
I see an error running go.sh about duplicate definitions. Any idea why? https://codereview.chromium.org/605853003/diff/1/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py ...
6 years, 2 months ago (2014-09-25 22:59:56 UTC) #2
rmacnak
6 years, 2 months ago (2014-09-30 06:53:12 UTC) #4
terry
https://chromiumcodereview.appspot.com/605853003/diff/60001/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://chromiumcodereview.appspot.com/605853003/diff/60001/tools/dom/scripts/htmldartgenerator.py#newcode217 tools/dom/scripts/htmldartgenerator.py:217: return Ryan, The problem is that there are now ...
6 years, 2 months ago (2014-09-30 15:01:56 UTC) #5
terry
https://chromiumcodereview.appspot.com/605853003/diff/60001/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://chromiumcodereview.appspot.com/605853003/diff/60001/tools/dom/scripts/htmldartgenerator.py#newcode217 tools/dom/scripts/htmldartgenerator.py:217: return On 2014/09/30 15:01:55, terry wrote: > Ryan, > ...
6 years, 2 months ago (2014-09-30 15:30:54 UTC) #6
vsm
lgtm once terry's comment is resolved https://chromiumcodereview.appspot.com/605853003/diff/60001/tests/html/fontface_loaded_test.dart File tests/html/fontface_loaded_test.dart (right): https://chromiumcodereview.appspot.com/605853003/diff/60001/tests/html/fontface_loaded_test.dart#newcode42 tests/html/fontface_loaded_test.dart:42: expect(fontFace.load(), throws); Test ...
6 years, 2 months ago (2014-09-30 18:22:27 UTC) #7
rmacnak
I'm thinking it makes more sense to forward the overloaded ones in a later CL ...
6 years, 2 months ago (2014-10-02 01:32:13 UTC) #8
rmacnak
6 years, 2 months ago (2014-10-14 23:47:12 UTC) #9
vsm
lgtm
6 years, 2 months ago (2014-10-15 22:27:10 UTC) #10
rmacnak
6 years, 2 months ago (2014-10-16 01:17:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #8 (id:140001) manually as 41136 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698