Make subtype test stubs isolate-specific.

Make subtype test stubs isolate-specific.

This avoids loading the current isolate from the context
register and makes those stubs not depend on having the context
stored in the CTX register.

R=vegorov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40714

[Florian Schneider, 2014-09-26 12:59:33]

fschneider@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2014-09-26 13:09:43]

lgtm

https://codereview.chromium.org/605533003/diff/1/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/605533003/diff/1/runtime/vm/assembler_arm.cc#...
runtime/vm/assembler_arm.cc:1733: Isolate* isolate) {
Can we make isolate member of the assembler?

https://codereview.chromium.org/605533003/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/605533003/diff/1/runtime/vm/isolate.h#newcode151
runtime/vm/isolate.h:151: + Isolate::class_table_offset()
just add TableAddress() getter to ClassTable that is defined as &table_

there is already ClassStatsTableAddress there.

Then you can do isolate->class_table()->TableAddress().

[Florian Schneider, 2014-09-26 14:05:02]

https://codereview.chromium.org/605533003/diff/1/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/605533003/diff/1/runtime/vm/assembler_arm.cc#...
runtime/vm/assembler_arm.cc:1733: Isolate* isolate) {
On 2014/09/26 13:09:43, Vyacheslav Egorov (Google) wrote:
> Can we make isolate member of the assembler?

Yes, this would be a bigger change (since we should also replace all uses of
Isolate::Current in the assembler then. For now I'll use Isolate::Current
instead.

https://codereview.chromium.org/605533003/diff/1/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/605533003/diff/1/runtime/vm/isolate.h#newcode151
runtime/vm/isolate.h:151: + Isolate::class_table_offset()
On 2014/09/26 13:09:43, Vyacheslav Egorov (Google) wrote:
> just add TableAddress() getter to ClassTable that is defined as &table_
> 
> there is already ClassStatsTableAddress there.
> 
> Then you can do isolate->class_table()->TableAddress().

Done.

[Florian Schneider, 2014-09-26 16:06:41]

Committed patchset #4 (id:60001) manually as r40714 (presubmit successful).