Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 60553002: Add test that makes sure print deals with broken toStrings. (Closed)

Created:
7 years, 1 month ago by floitsch
Modified:
7 years, 1 month ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add test that makes sure print deals with broken toStrings. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=29994

Patch Set 1 #

Patch Set 2 : Add corelib test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -5 lines) Patch
A + tests/corelib/print_test.dart View 1 1 chunk +11 lines, -5 lines 0 comments Download
A tests/lib/async/print_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
7 years, 1 month ago (2013-11-05 18:17:46 UTC) #1
ahe
LGTM. Would it make sense to add another test which doesn't run in a zone? ...
7 years, 1 month ago (2013-11-05 22:05:18 UTC) #2
floitsch
PTAL.
7 years, 1 month ago (2013-11-05 22:59:06 UTC) #3
ahe
LGTM!
7 years, 1 month ago (2013-11-06 11:44:48 UTC) #4
floitsch
7 years, 1 month ago (2013-11-06 20:40:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698