Issue 605343002: Per-mille parsing was dividing by 100, not 1000

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 605343002: Per-mille parsing was dividing by 100, not 1000 (Closed)

Created:
6 years, 2 months ago by Alan Knight

Modified:
6 years, 2 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Per-mille parsing was dividing by 100, not 1000 BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=40726

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -9 lines)			Patch
	M	pkg/intl/lib/src/intl/number_format.dart	View		5 chunks	+5 lines, -5 lines	1 comment	Download
	M	pkg/intl/test/number_format_test.dart	View		4 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Emily Fortuna

lgtm! https://codereview.chromium.org/605343002/diff/1/pkg/intl/lib/src/intl/number_format.dart File pkg/intl/lib/src/intl/number_format.dart (right): https://codereview.chromium.org/605343002/diff/1/pkg/intl/lib/src/intl/number_format.dart#newcode502 pkg/intl/lib/src/intl/number_format.dart:502: scale = 1000; whoops!

6 years, 2 months ago (2014-09-26 18:01:50 UTC) #3

Alan Knight

6 years, 2 months ago (2014-09-26 18:05:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40726 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages