Don't use the size-zero array hack to access variable data in Snapshot.

Don't use the size-zero array hack to access variable data in Snapshot.

Avoids C4200 from MSVS "nonstandard extension used : zero-sized array in struct/union".

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40657

[rmacnak, 2014-09-24 20:58:46]

rmacnak@google.com changed reviewers:
+ asiva@google.com

[siva, 2014-09-24 22:02:53]

lgtm

https://codereview.chromium.org/604553003/diff/1/runtime/vm/snapshot.h
File runtime/vm/snapshot.h (right):

https://codereview.chromium.org/604553003/diff/1/runtime/vm/snapshot.h#newcod...
runtime/vm/snapshot.h:177: const uint8_t* content() const {
OPEN_ARRAY_START(uint8_t, uint8_t); }
Why not move this block to the top above the 'private:' stuff?

[rmacnak, 2014-09-24 22:38:08]

https://codereview.chromium.org/604553003/diff/1/runtime/vm/snapshot.h
File runtime/vm/snapshot.h (right):

https://codereview.chromium.org/604553003/diff/1/runtime/vm/snapshot.h#newcod...
runtime/vm/snapshot.h:177: const uint8_t* content() const {
OPEN_ARRAY_START(uint8_t, uint8_t); }
On 2014/09/24 22:02:53, siva wrote:
> Why not move this block to the top above the 'private:' stuff?

The intention was for content() to appear in the position the data occupies on
the object, a la raw_object.h. Leaving content() private and marking users as
friends as discussed offline doesn't work because one of the users in an API
function and friend doesn't play well with DART_EXPORT. Moving content() back to
the public block.

[rmacnak, 2014-09-24 22:51:37]

Committed patchset #3 (id:40001) manually as 40657 (presubmit successful).