Issue 604333002: Specify when 'sortMembers' will return an error.

Issue 604333002: Specify when 'sortMembers' will return an error. (Closed)

Created:
6 years, 2 months ago by scheglov

Modified:
6 years, 2 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Specify when 'sortMembers' will return an error. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40719

Patch Set 3 : Specify the specific error codes #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -0 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RequestErrorCode.java	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	1 2	2 chunks	+21 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	1 2	3 chunks	+18 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_test_methods.dart	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	1 2	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

https://codereview.chromium.org/604333002/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/604333002/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode1295 pkg/analysis_server/tool/spec/spec_input.html:1295: errors. Do you know the specific errors that will ...

6 years, 2 months ago (2014-09-26 16:45:43 UTC) #2

scheglov

Paul, PTAL https://codereview.chromium.org/604333002/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/604333002/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode1295 pkg/analysis_server/tool/spec/spec_input.html:1295: errors. On 2014/09/26 16:45:42, Paul Berry wrote: ...

6 years, 2 months ago (2014-09-26 16:55:39 UTC) #4

scheglov

6 years, 2 months ago (2014-09-26 17:12:38 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 40719 (presubmit successful).

Expand Messages | Collapse Messages