Issue 60423007: Add 'declarations' getter in JsTypeBoundClassMirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60423007: Add 'declarations' getter in JsTypeBoundClassMirror. (Closed)

Created:
7 years, 1 month ago by zarah

Modified:
7 years, 1 month ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add 'declarations' getter in JsTypeBoundClassMirror. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=29968

Patch Set 2 : Added newline. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -25 lines)			Patch
	M	sdk/lib/_internal/lib/js_mirrors.dart	View	1	10 chunks	+61 lines, -25 lines	0 comments	Download
	A	tests/lib/mirrors/generic_class_declaration_test.dart	View		1 chunk	+83 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/60423007/diff/50001/sdk/lib/_internal/lib/js_mirrors.dart File sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/60423007/diff/50001/sdk/lib/_internal/lib/js_mirrors.dart#newcode206 sdk/lib/_internal/lib/js_mirrors.dart:206: bool get isTopLevel => false; Add newline before.

7 years, 1 month ago (2013-11-06 11:41:35 UTC) #2

zarah

Committed patchset #2 manually as r29968 (presubmit successful).

7 years, 1 month ago (2013-11-06 12:20:12 UTC) #3

zarah

7 years, 1 month ago (2013-11-06 12:32:23 UTC) #4

Message was sent while issue was closed.

Thanks.

https://codereview.chromium.org/60423007/diff/50001/sdk/lib/_internal/lib/js_...
File sdk/lib/_internal/lib/js_mirrors.dart (right):

https://codereview.chromium.org/60423007/diff/50001/sdk/lib/_internal/lib/js_...
sdk/lib/_internal/lib/js_mirrors.dart:206: bool get isTopLevel => false;
On 2013/11/06 11:41:36, ahe wrote:
> Add newline before.

Done.

Expand Messages | Collapse Messages

Issue 60423007: Add 'declarations' getter in JsTypeBoundClassMirror. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : Added newline. #

Messages