Issue 603943005: Resubmit reverted r40623 unchanged after GC issue fixed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 603943005: Resubmit reverted r40623 unchanged after GC issue fixed. (Closed)

Created:
6 years, 2 months ago by regis

Modified:
6 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Resubmit reverted r40623 unchanged after GC issue fixed. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40815

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -37 lines)			Patch
M	runtime/lib/bigint.dart	View	1	2 chunks	+31 lines, -30 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View		6 chunks	+150 lines, -7 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/method_recognizer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

regis

Just asking for a rubberstamp. This is exactly what was reverted and hopefully what will ...

6 years, 2 months ago (2014-09-25 22:31:45 UTC) #2

regis

6 years, 2 months ago (2014-09-30 16:21:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r40815 (presubmit successful).