Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 603743002: Break out WeakCodeReferences to own file in preparation to use it outside object.cc. (Closed)

Created:
6 years, 3 months ago by koda
Modified:
6 years, 3 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Break out WeakCodeReferences to own file in preparation to use it outside object.cc. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -116 lines) Patch
M runtime/vm/object.cc View 2 chunks +1 line, -116 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/vm/weak_code.h View 1 chunk +40 lines, -0 lines 0 comments Download
A runtime/vm/weak_code.cc View 1 chunk +132 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 3 months ago (2014-09-24 20:06:04 UTC) #1
koda
This is intended to be a pure refactoring. Actual changes will come in follow-up CL.
6 years, 3 months ago (2014-09-24 20:08:11 UTC) #2
srdjan
lgtm
6 years, 3 months ago (2014-09-24 22:04:02 UTC) #3
koda
6 years, 3 months ago (2014-09-24 22:43:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r40656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698