Update TodoMVC based on https://github.com/polymer/todomvc

Update TodoMVC based on https://github.com/polymer/todomvc

Other than the TodoMVC changes, this has 2 polymer fixes:
* removes incorrect linter messages
* fix issue 12434 -- external stylesheets did not work

port is of d33386ccd4c84cb5b89391bd958e97c5de7c2a01

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30387

[Jennifer Messerly, 2013-11-07 01:30:25]

Hi Dan, Siggi,

Thoughts on whether this is worth trying to land now or wait a bit? It's a
pretty significant improvement & much more illustrative, but of course has risk.

For what it's worth, I did manual testing of Firefox and Chrome w/ "pub build",
Dartium, the automated tests, and used Editor to verify no "problems" in the
code.

Either way, let me know if this looks good. I can hold off on checking if
needed.

Thanks!
- John

[Siggi Cherem (dart-lang), 2013-11-07 02:12:47]

overall the code looks great. But I am also not sure whether we want to submit
now or in a couple weeks. Dan?

Minor comments below. Also, might be worth adding a TODO to delete
polymer-selection and whatever else we expect to be part of the polymer-elements
package in the future.

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
File samples/third_party/todomvc/web/app/app.css (right):

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
samples/third_party/todomvc/web/app/app.css:20: /* font-smoothing: antialiased;
*/
I assume these are edits to remove warnings in dartium?

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
File samples/third_party/todomvc/web/elements/td_model.dart (right):

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
samples/third_party/todomvc/web/elements/td_model.dart:23: @observable
ObservableList<Todo> items;
should we use @published for the few attributes that are visible? (items,
filter, storatgeId)?

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
File samples/third_party/todomvc/web/elements/td_todos.dart (right):

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
samples/third_party/todomvc/web/elements/td_todos.dart:10: @observable String
modelId;
@published?

[Jennifer Messerly, 2013-11-07 04:27:35]

yeah, I'll try switching everything over to @published ... cleaner IMO

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
File samples/third_party/todomvc/web/app/app.css (right):

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
samples/third_party/todomvc/web/app/app.css:20: /* font-smoothing: antialiased;
*/
On 2013/11/07 02:12:47, Siggi Cherem (dart-lang) wrote:
> I assume these are edits to remove warnings in dartium?

Yup! I'm not sure if it's a good idea, but also seems relatively harmless.

(Generally browsers are going to issue CSS property warnings, it's just a thing
they do... the sample has tons of warnings in Firefox, for example)

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
File samples/third_party/todomvc/web/elements/td_model.dart (right):

https://codereview.chromium.org/60353013/diff/20001/samples/third_party/todom...
samples/third_party/todomvc/web/elements/td_model.dart:23: @observable
ObservableList<Todo> items;
On 2013/11/07 02:12:47, Siggi Cherem (dart-lang) wrote:
> should we use @published for the few attributes that are visible? (items,
> filter, storatgeId)?

yeah, I wondered that too. Polymer-js version isn't using "publish" for any of
these. But it seems a lot nicer -- less boilerplate. (especially if we rename it
to @attribute)

[Jennifer Messerly, 2013-11-07 04:39:03]

patch set 3 switches to @published instead of attribute=

[Siggi Cherem (dart-lang), 2013-11-07 21:44:05]

lgtm

[Jennifer Messerly, 2013-11-19 04:29:07]

Committed patchset #4 manually as r30387 (presubmit successful).