Issue 603493002: Revert r40623, "Refactor bigint _sqrTo in preparation of intrinsification."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 603493002: Revert r40623, "Refactor bigint _sqrTo in preparation of intrinsification." (Closed)

Created:
6 years, 2 months ago by Bill Hesse

Modified:
6 years, 2 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert r40623, "Refactor bigint _sqrTo in preparation of intrinsification." This reverts commit r40623, https://codereview.chromium.org//600533002, which is failing snapshot generation on x64 and arm architectures. BUG=dartbug.com/21061 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=40628

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -203 lines)			Patch
M	runtime/lib/bigint.dart	View	2 chunks	+30 lines, -31 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	6 chunks	+7 lines, -150 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/method_recognizer.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Bill Hesse

6 years, 2 months ago (2014-09-24 09:40:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40628 (presubmit successful).