Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 603353003: Change type of multiplier to int, not _Smi. (Closed)

Created:
6 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Change type of multiplier to int, not _Smi. Committed: https://code.google.com/p/dart/source/detail?r=40704

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/lib/integers_patch.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
This is actually Mint, but will mostly be multiplied with a bigint, so it makes ...
6 years, 2 months ago (2014-09-26 12:30:25 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 (id:1) manually as 40704 (presubmit successful).
6 years, 2 months ago (2014-09-26 12:30:42 UTC) #3
Søren Gjesse
6 years, 2 months ago (2014-09-29 05:51:56 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698