Issue 602943002: Allows arm cpu feature detection to detect arm64 cpus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 602943002: Allows arm cpu feature detection to detect arm64 cpus. (Closed)

Created:
6 years, 3 months ago by zra

Modified:
6 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Allows arm cpu feature detection to detect arm64 cpus. This is probalby of limited utility since we have an arm64 port, but it could be interesting for performance experiments, etc. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40678

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -11 lines)			Patch
	M	runtime/vm/cpu_arm.cc	View		3 chunks	+19 lines, -11 lines	0 comments	Download
	M	tools/gyp/configurations_android.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

regis

LGTM I guess it would make it possible to emit such a warning: "For better ...

6 years, 3 months ago (2014-09-25 01:05:00 UTC) #3

zra

6 years, 2 months ago (2014-09-25 14:38:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r40678 (presubmit successful).