Fix the listing of built-in packages for "pub build".

Fix the listing of built-in packages for "pub build".

R=rnystrom@google.com
BUG=21068
Committed: https://code.google.com/p/dart/source/detail?r=40649

[Bob Nystrom, 2014-09-24 20:29:29]

Couple of nits then LGTM.

https://codereview.chromium.org/602923002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart (right):

https://codereview.chromium.org/602923002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart:79: // "$pub" is
a psuedo-package that allows pub's transformer-loading
"psuedo" -> "pseudo".

https://codereview.chromium.org/602923002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart:90: } else if
(packageName == r'$sdk') {
The "else" isn't needed here.

https://codereview.chromium.org/602923002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart:102: } else {
Or here.

[nweiz, 2014-09-24 20:37:31]

Code review changes

[nweiz, 2014-09-24 20:37:39]

https://codereview.chromium.org/602923002/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart (right):

https://codereview.chromium.org/602923002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart:79: // "$pub" is
a psuedo-package that allows pub's transformer-loading
On 2014/09/24 20:29:29, Bob Nystrom wrote:
> "psuedo" -> "pseudo".

Done.

https://codereview.chromium.org/602923002/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart:90: } else if
(packageName == r'$sdk') {
On 2014/09/24 20:29:29, Bob Nystrom wrote:
> The "else" isn't needed here.

I like using it anyway when it reduces the line count. It also makes it
structurally clear that there are three options that are completely disjoint.

[nweiz, 2014-09-24 20:37:50]

Committed patchset #2 (id:20001) manually as 40649 (presubmit successful).