Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 602853002: Allow setting breakpoints specifying the suffix of a file path (Closed)

Created:
6 years, 3 months ago by hausner
Modified:
6 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, devoncarew, scheglov
Visibility:
Public.

Description

Allow setting breakpoints specifying the suffix of a file path In this version, the VM does not set a breakpoint if the url given matches the suffix of more than one loaded script. Partial matches must start with a path separator or with the character immediately following a path separator. E.g. d.dart will match /tmp/d.dart, but not /tmp/ed.dart. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=40736

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M runtime/vm/debugger.cc View 1 2 1 chunk +11 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hausner
Here's an improved version that requires that path elements must fully match, eliminating false ambiguous ...
6 years, 3 months ago (2014-09-24 20:24:49 UTC) #1
hausner
This is ready for review.
6 years, 3 months ago (2014-09-24 23:21:06 UTC) #3
siva
lgtm https://codereview.chromium.org/602853002/diff/20001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/602853002/diff/20001/runtime/vm/debugger.cc#newcode1907 runtime/vm/debugger.cc:1907: GrowableObjectArray::Handle(GrowableObjectArray::New()); ....Handle(isolate_, GrowableObjectArray::New()); since you already have the ...
6 years, 2 months ago (2014-09-26 20:02:48 UTC) #4
hausner
Committed patchset #3 (id:40001) manually as r40736 (presubmit successful).
6 years, 2 months ago (2014-09-26 20:11:30 UTC) #5
hausner
6 years, 2 months ago (2014-09-26 20:19:12 UTC) #6
Message was sent while issue was closed.
Thank you.

https://codereview.chromium.org/602853002/diff/20001/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://codereview.chromium.org/602853002/diff/20001/runtime/vm/debugger.cc#n...
runtime/vm/debugger.cc:1907:
GrowableObjectArray::Handle(GrowableObjectArray::New());
On 2014/09/26 20:02:48, siva wrote:
> ....Handle(isolate_, GrowableObjectArray::New());
> 
> since you already have the isolate value.

Done.

Powered by Google App Engine
This is Rietveld 408576698