Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 601083005: Implement 'edit.sortMembers' request. (Closed)

Created:
6 years, 2 months ago by scheglov
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Forgot to add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -1 line) Patch
M pkg/analysis_server/lib/src/constants.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 3 chunks +42 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/edit/sort_members_test.dart View 1 1 chunk +167 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/test_all.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scheglov
6 years, 2 months ago (2014-09-26 19:31:50 UTC) #1
Paul Berry
lgtm
6 years, 2 months ago (2014-09-26 19:36:25 UTC) #2
scheglov
I forgot to include new tests file :-(
6 years, 2 months ago (2014-09-26 19:56:55 UTC) #3
Paul Berry
lgtm
6 years, 2 months ago (2014-09-26 20:04:17 UTC) #4
scheglov
Committed patchset #2 (id:20001) manually as 40735 (presubmit successful).
6 years, 2 months ago (2014-09-26 20:09:27 UTC) #5
Brian Wilkerson
6 years, 2 months ago (2014-09-26 21:22:28 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698