Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 600293002: Add some additional annotations for tracking pub performance. (Closed)

Created:
6 years, 3 months ago by nweiz
Modified:
6 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add some additional annotations for tracking pub performance. This also makes pub print more detailed timing information in --verbose mode. R=rnystrom@google.com BUG=20859 Committed: https://code.google.com/p/dart/source/detail?r=41407

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -73 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 chunk +25 lines, -26 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 2 chunks +21 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart View 2 chunks +39 lines, -11 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart View 1 chunk +116 lines, -26 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/utils.dart View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 3 months ago (2014-09-25 01:16:16 UTC) #1
Bob Nystrom
Couple of nits then LGTM! https://codereview.chromium.org/600293002/diff/1/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart File sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart (right): https://codereview.chromium.org/600293002/diff/1/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart#newcode84 sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart:84: }); How about `fine: ...
6 years, 2 months ago (2014-10-14 23:54:04 UTC) #2
nweiz
Code review changes
6 years, 1 month ago (2014-10-29 21:24:44 UTC) #3
nweiz
https://codereview.chromium.org/600293002/diff/1/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart File sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart (right): https://codereview.chromium.org/600293002/diff/1/sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart#newcode84 sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart:84: }); On 2014/10/14 23:54:04, Bob Nystrom wrote: > How ...
6 years, 1 month ago (2014-10-29 21:24:48 UTC) #4
nweiz
6 years, 1 month ago (2014-10-29 21:48:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41407 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698