Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 600273004: Remove the assumption that stat64 and lstat64 cannot return EINTR on Linux (Closed)

Created:
6 years, 3 months ago by Søren Gjesse
Modified:
6 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove the assumption that stat64 and lstat64 cannot return EINTR on Linux BUG=http://dartbug.com/21080 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=40671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M runtime/bin/directory_linux.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/file_linux.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Søren Gjesse
6 years, 3 months ago (2014-09-25 07:03:34 UTC) #1
Anders Johnsen
LGTM
6 years, 3 months ago (2014-09-25 07:05:14 UTC) #2
Søren Gjesse
Committed patchset #1 (id:1) manually as 40671 (presubmit successful).
6 years, 3 months ago (2014-09-25 07:06:13 UTC) #3
Ivan Posva
6 years, 2 months ago (2014-09-26 21:06:24 UTC) #4
Message was sent while issue was closed.
What about the other lstat and related calls on Android or MacOS?

-Ivan

Powered by Google App Engine
This is Rietveld 408576698