Issue 600243002: Patchable AllocateArray stub, like instance allocation stubs.

Issue 600243002: Patchable AllocateArray stub, like instance allocation stubs. (Closed)

Created:
6 years, 3 months ago by koda

Modified:
6 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Make AllocateArray stub patchable, like instance allocation stubs. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=40699

Patch Set 5 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -60 lines)			Patch
M	runtime/vm/heap.cc	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/instructions_arm64_test.cc	View	1 2 3 4	2 chunks	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/instructions_arm_test.cc	View	1 2 3 4	4 chunks	+12 lines, -10 lines	0 comments	Download
M	runtime/vm/instructions_ia32_test.cc	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/instructions_mips_test.cc	View	1 2 3 4	2 chunks	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/instructions_x64_test.cc	View	1 2 3 4	2 chunks	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 2 3 4	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3 4	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1 2 3	6 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/vm/stub_code.cc	View	1 2	4 chunks	+16 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2 3 4	4 chunks	+30 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 2 3 4	4 chunks	+33 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3	4 chunks	+34 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 2 3 4	4 chunks	+38 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3 4	4 chunks	+34 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

koda

If the interface looks good to you, I will port it to all archs and ...

6 years, 3 months ago (2014-09-24 23:23:05 UTC) #2

srdjan

https://chromiumcodereview.appspot.com/600243002/diff/40001/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://chromiumcodereview.appspot.com/600243002/diff/40001/runtime/vm/heap.cc#newcode372 runtime/vm/heap.cc:372: if ((cid >= kNumPredefinedCids || cid == kArrayCid) && ...

6 years, 2 months ago (2014-09-25 17:42:53 UTC) #3

koda

PTAL https://chromiumcodereview.appspot.com/600243002/diff/40001/runtime/vm/heap.cc File runtime/vm/heap.cc (right): https://chromiumcodereview.appspot.com/600243002/diff/40001/runtime/vm/heap.cc#newcode372 runtime/vm/heap.cc:372: if ((cid >= kNumPredefinedCids || cid == kArrayCid) ...

6 years, 2 months ago (2014-09-25 21:49:26 UTC) #4

koda

6 years, 2 months ago (2014-09-25 23:31:18 UTC) #8

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as r40699 (presubmit successful).

Expand Messages | Collapse Messages