Make catch_errors13_test non-flaky.

Make catch_errors13_test non-flaky.

Was flaky on buildbot:
http://build.chromium.org/p/client.dart/builders/dartium-mac-debug-be/builds/410/steps/drt_core_checked_tests/logs/stdio

R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30087

[sra1, 2013-11-08 00:09:02]

lgtm

https://codereview.chromium.org/60013013/diff/1/tests/lib/async/catch_errors1...
File tests/lib/async/catch_errors13_test.dart (right):

https://codereview.chromium.org/60013013/diff/1/tests/lib/async/catch_errors1...
tests/lib/async/catch_errors13_test.dart:36: } else if
(outerTimerCounterDelayCount < 100) {
What is significant about "100" ?

It seems to me if the original test was slightly nondeterministic for valid
reasons, the test should check for correct nondeterministic behaviour, e.g all
errors are reported, some errors must precede others etc.

Perhaps have two tests: the new test with forced order, and the original
checking only that the set of errors is reported.

[floitsch, 2013-11-08 00:19:51]

https://codereview.chromium.org/60013013/diff/1/tests/lib/async/catch_errors1...
File tests/lib/async/catch_errors13_test.dart (right):

https://codereview.chromium.org/60013013/diff/1/tests/lib/async/catch_errors1...
tests/lib/async/catch_errors13_test.dart:36: } else if
(outerTimerCounterDelayCount < 100) {
On 2013/11/08 00:09:02, sra1 wrote:
> What is significant about "100" ?
> 
> It seems to me if the original test was slightly nondeterministic for valid
> reasons, the test should check for correct nondeterministic behaviour, e.g all
> errors are reported, some errors must precede others etc.
> 
> Perhaps have two tests: the new test with forced order, and the original
> checking only that the set of errors is reported.

I prefer making it deterministic. Added a comment.

[floitsch, 2013-11-08 00:20:19]

Committed patchset #3 manually as r30087 (presubmit successful).