Get binstubs working on Windows.

Get binstubs working on Windows.

Committed: https://code.google.com/p/dart/source/detail?r=40667

[Bob Nystrom, 2014-09-25 05:38:59]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[Bob Nystrom, 2014-09-25 05:39:00]

TBR.

[Bob Nystrom, 2014-09-25 05:43:38]

Committed patchset #2 (id:20001) manually as 40667 (presubmit successful).

[nweiz, 2014-09-25 19:41:14]

lgtm

https://codereview.chromium.org/599343003/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (left):

https://codereview.chromium.org/599343003/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/global_packages.dart:634: }
Why not include "%APPDATA%"?

[Bob Nystrom, 2014-09-25 19:48:16]

https://codereview.chromium.org/599343003/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (left):

https://codereview.chromium.org/599343003/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/global_packages.dart:634: }
On 2014/09/25 19:41:14, nweiz wrote:
> Why not include "%APPDATA%"?

On POSIX, you'll be adding to your path in a shell script which does path
expansion for you. On Windows, you're configuring the Path environment variable
directly as a raw string and (I believe), it doesn't handle any environment
variables. None of the other paths I saw in mine had any, so I figured using the
full path was safest.