Issue 59933004: In preparation of inlining remainder and modulo binary Smi operations:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59933004: In preparation of inlining remainder and modulo binary Smi operations: (Closed)

Created:
7 years, 1 month ago by srdjan

Modified:
7 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

In preparation of inlining remainder and modulo binary Smi operations: - Add REM token - Fix checking of function fingerprints. - Remove unused intrinsic for remainder (the function gets inlined and intrinsic is not generated) R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=29929

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+190 lines, -298 lines)			Patch
M	runtime/bin/main.cc	View	4 chunks	+0 lines, -21 lines	0 comments	Download
M	runtime/include/dart_native_api.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/lib/integers.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 chunk	+15 lines, -15 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	4 chunks	+85 lines, -85 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	2 chunks	+81 lines, -82 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	runtime/vm/native_api_impl.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	runtime/vm/token.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

7 years, 1 month ago (2013-11-05 19:27:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29929 (presubmit successful).

Expand Messages | Collapse Messages