Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 599133002: Move PubPackageMapProvider to its own file. (Closed)

Created:
6 years, 3 months ago by Paul Berry
Modified:
6 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move PubPackageMapProvider to its own file. This will allow clients of the AnalysisServer package to provide their own PackageMapProvider without bringing in a dependency on dart:io. R=brianwilkerson@google.com, rpaquay@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=40638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -165 lines) Patch
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/package_map_provider.dart View 2 chunks +0 lines, -126 lines 0 comments Download
A + pkg/analyzer/lib/source/pub_package_map_provider.dart View 1 chunk +2 lines, -38 lines 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/source/package_map_provider_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 3 months ago (2014-09-24 16:18:11 UTC) #2
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-24 16:26:44 UTC) #3
rpaquay
lgtm
6 years, 3 months ago (2014-09-24 17:24:36 UTC) #4
Paul Berry
6 years, 3 months ago (2014-09-24 18:09:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40638 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698