Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 599053002: Temporary disable until co19 tests are updated for 38 roll (Closed)

Created:
6 years, 3 months ago by terry
Modified:
6 years, 3 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Temporary disable until co19 tests are updated for 38 roll Reviewers=vsm@google.com R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=40630

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added issue 21075 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/co19/co19-co19.status View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
terry
I want to land this CL before I get the co19 folks to change the ...
6 years, 3 months ago (2014-09-24 15:11:58 UTC) #2
vsm
lgtm with comment https://codereview.chromium.org/599053002/diff/1/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/599053002/diff/1/tests/co19/co19-co19.status#newcode19 tests/co19/co19-co19.status:19: # TODO(terry) re-enable the below CSS ...
6 years, 3 months ago (2014-09-24 15:29:37 UTC) #3
terry
https://codereview.chromium.org/599053002/diff/1/tests/co19/co19-co19.status File tests/co19/co19-co19.status (right): https://codereview.chromium.org/599053002/diff/1/tests/co19/co19-co19.status#newcode19 tests/co19/co19-co19.status:19: # TODO(terry) re-enable the below CSS tests when Chrome ...
6 years, 3 months ago (2014-09-24 15:55:20 UTC) #4
terry
6 years, 3 months ago (2014-09-24 15:55:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 40630 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698