Issue 598493003: Give up tracing of a function if one of its closurizations escapes tracing.

Issue 598493003: Give up tracing of a function if one of its closurizations escapes tracing. (Closed)

Created:
6 years, 3 months ago by karlklose

Modified:
6 years, 3 months ago

Reviewers:
herhut

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Give up tracing of a function if one of its closurizations escapes tracing. R=herhut@google.com BUG= http://dartbug.com/21016 Committed: https://code.google.com/p/dart/source/detail?r=40591

Patch Set 2 : Remove noop loop. #

Patch Set 3 : Change test to pass the analyzer. #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -9 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart	View		2 chunks	+14 lines, -2 lines	0 comments	Download
A	tests/language/regress_21016_test.dart	View	1 2	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

herhut

lgtm w/ comment. https://codereview.chromium.org/598493003/diff/1/sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart File sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart (right): https://codereview.chromium.org/598493003/diff/1/sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart#newcode16 sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart:16: for (FunctionElement e in tracedElements) { ...

6 years, 3 months ago (2014-09-23 13:03:43 UTC) #2

karlklose

https://codereview.chromium.org/598493003/diff/1/sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart File sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart (right): https://codereview.chromium.org/598493003/diff/1/sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart#newcode16 sdk/lib/_internal/compiler/implementation/inferrer/closure_tracer.dart:16: for (FunctionElement e in tracedElements) { Removed.

6 years, 3 months ago (2014-09-23 13:08:08 UTC) #3

karlklose

6 years, 3 months ago (2014-09-23 13:17:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 40591 (presubmit successful).

Expand Messages | Collapse Messages