Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 597773003: Have barback lazily load assets from static pub packages. (Closed)

Created:
6 years, 2 months ago by nweiz
Modified:
6 years, 2 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Have barback lazily load assets from static pub packages. This takes "pub run new_element --help" from about 1.75s to about 1.60s. R=rnystrom@google.com BUG=20859 Committed: https://code.google.com/p/dart/source/detail?r=40619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -22 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/asset_environment.dart View 2 chunks +5 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/pub_package_provider.dart View 2 chunks +16 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/package_graph.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/barback/asset_environment.dart View 2 chunks +45 lines, -8 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/barback/pub_package_provider.dart View 2 chunks +16 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/package_graph.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 2 months ago (2014-09-24 00:03:27 UTC) #1
Bob Nystrom
LGTM!
6 years, 2 months ago (2014-09-24 00:24:10 UTC) #2
nweiz
6 years, 2 months ago (2014-09-24 00:25:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40619 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698