- Add a per-isolate pseudo random number generator to the

- Add a per-isolate pseudo random number generator to the
  VM internals. This PRNG is not used to generate random
  numbers in Dart code.
- Use the PRNG to generate JIT cookies for large constants
  if needed during assembly.
- Add the possibility to set an external entropy source
  for the PRNG through the C API.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29950

[siva, 2013-11-05 23:37:46]

lgtm

https://codereview.chromium.org/59773007/diff/1/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/59773007/diff/1/runtime/bin/dartutils.cc#newc...
runtime/bin/dartutils.cc:15: #include "bin/directory.h"
extensions.h should come here in the order.

https://codereview.chromium.org/59773007/diff/1/runtime/bin/dartutils.cc#newc...
runtime/bin/dartutils.cc:19: #include "bin/socket.h"
socket.h should go before.

[Ivan Posva, 2013-11-05 23:44:55]

Thanks!

-Ivan

https://codereview.chromium.org/59773007/diff/1/runtime/bin/dartutils.cc
File runtime/bin/dartutils.cc (right):

https://codereview.chromium.org/59773007/diff/1/runtime/bin/dartutils.cc#newc...
runtime/bin/dartutils.cc:15: #include "bin/directory.h"
On 2013/11/05 23:37:46, siva wrote:
> extensions.h should come here in the order.

Done.

https://codereview.chromium.org/59773007/diff/1/runtime/bin/dartutils.cc#newc...
runtime/bin/dartutils.cc:19: #include "bin/socket.h"
On 2013/11/05 23:37:46, siva wrote:
> socket.h should go before.

Done.

[jschuh, 2013-11-06 00:27:12]

Looks basically the same as the v8 implementation on the security front. lgtm.

[Ivan Posva, 2013-11-06 00:59:57]

Committed patchset #1 manually as r29950 (presubmit successful).