Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 59763006: add versions and constraints for packages and samples (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add versions and constraints for packages and samples - all packages at 0.9.0, except "analyzer" which had a version already - dependencies at ">=0.9.0 <0.10.0" except analyzer is ">=0.10.0 <0.11.0" - sdk constraint ">=1.0.0 <2.0.0" R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29957

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : also add sdk constraint to samples #

Total comments: 9

Patch Set 4 : update a few more constraints #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -248 lines) Patch
M pkg/analyzer/pubspec.yaml View 1 chunk +7 lines, -5 lines 0 comments Download
M pkg/args/pubspec.yaml View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/async_helper/pubspec.yaml View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/barback/pubspec.yaml View 2 chunks +8 lines, -5 lines 0 comments Download
M pkg/browser/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/collection_helpers/pubspec.yaml View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/crypto/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/csslib/pubspec.yaml View 1 chunk +9 lines, -6 lines 0 comments Download
M pkg/custom_element/pubspec.yaml View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/docgen/pubspec.yaml View 1 chunk +11 lines, -6 lines 0 comments Download
M pkg/expect/pubspec.yaml View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/fixnum/pubspec.yaml View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/html_import/pubspec.yaml View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/http/pubspec.yaml View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/http_server/pubspec.yaml View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/intl/pubspec.yaml View 1 chunk +7 lines, -5 lines 0 comments Download
M pkg/json/pubspec.yaml View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/logging/pubspec.yaml View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/mime/pubspec.yaml View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/mutation_observer/pubspec.yaml View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/oauth2/pubspec.yaml View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/observe/pubspec.yaml View 2 chunks +9 lines, -6 lines 0 comments Download
M pkg/path/pubspec.yaml View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 2 chunks +20 lines, -18 lines 0 comments Download
M pkg/polymer_expressions/pubspec.yaml View 1 chunk +7 lines, -4 lines 0 comments Download
M pkg/scheduled_test/pubspec.yaml View 1 2 3 2 chunks +7 lines, -4 lines 0 comments Download
M pkg/sequence_zip/pubspec.yaml View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/serialization/pubspec.yaml View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/shadow_dom/pubspec.yaml View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/source_maps/pubspec.yaml View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/stack_trace/pubspec.yaml View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/template_binding/pubspec.yaml View 1 chunk +8 lines, -5 lines 0 comments Download
M pkg/third_party/html5lib/pubspec.yaml View 1 chunk +8 lines, -5 lines 0 comments Download
M pkg/unittest/pubspec.yaml View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/unmodifiable_collection/pubspec.yaml View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/utf/pubspec.yaml View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/watcher/pubspec.yaml View 2 chunks +7 lines, -4 lines 0 comments Download
M pkg/yaml/pubspec.yaml View 1 chunk +4 lines, -1 line 0 comments Download
M samples/build_dart/pubspec.yaml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/clock/pubspec.yaml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/dartiverse_search/pubspec.yaml View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M samples/dgrep/pubspec.yaml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/gauge/pubspec.yaml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/google_maps/pubspec.yaml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/jsonp/pubspec.yaml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/solar/pubspec.yaml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/sunflower/pubspec.yaml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/swipe/pubspec.yaml View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/third_party/angular_todo/pubspec.yaml View 1 2 3 1 chunk +6 lines, -4 lines 0 comments Download
M samples/third_party/pop-pop-win/pubspec.yaml View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M samples/third_party/todomvc/pubspec.yaml View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M samples/tracker/pubspec.yaml View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M tools/publish_all_pkgs.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/publish_pkg.py View 2 chunks +45 lines, -120 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jennifer Messerly
7 years, 1 month ago (2013-11-06 03:05:15 UTC) #1
Jennifer Messerly
7 years, 1 month ago (2013-11-06 03:09:13 UTC) #2
Siggi Cherem (dart-lang)
only couple questions below, but otherwise lgtm https://codereview.chromium.org/59763006/diff/60001/pkg/scheduled_test/pubspec.yaml File pkg/scheduled_test/pubspec.yaml (right): https://codereview.chromium.org/59763006/diff/60001/pkg/scheduled_test/pubspec.yaml#newcode16 pkg/scheduled_test/pubspec.yaml:16: unittest: ">=0.4.3 ...
7 years, 1 month ago (2013-11-06 03:19:42 UTC) #3
Jennifer Messerly
Thanks Siggi. https://codereview.chromium.org/59763006/diff/60001/pkg/scheduled_test/pubspec.yaml File pkg/scheduled_test/pubspec.yaml (right): https://codereview.chromium.org/59763006/diff/60001/pkg/scheduled_test/pubspec.yaml#newcode16 pkg/scheduled_test/pubspec.yaml:16: unittest: ">=0.4.3 <1.0.0" On 2013/11/06 03:19:43, Siggi ...
7 years, 1 month ago (2013-11-06 03:26:53 UTC) #4
Jennifer Messerly
Committed patchset #4 manually as r29957 (presubmit successful).
7 years, 1 month ago (2013-11-06 03:28:34 UTC) #5
dgrove
7 years, 1 month ago (2013-11-06 04:31:49 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698