Issue 597363002: Fixing treeshaking problem with 37 roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 597363002: Fixing treeshaking problem with 37 roll (Closed)

Created:
6 years, 2 months ago by terry

Modified:
6 years, 2 months ago

Reviewers:
vsm, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

terry

Stephen can you patch in the sdk/libs and see if this fixes your extra 60K ...

6 years, 2 months ago (2014-09-24 20:21:04 UTC) #2

terry

One more try. This reduced swarm by 70K back to where we were. I've also ...

6 years, 2 months ago (2014-09-24 21:29:00 UTC) #5

terry

6 years, 2 months ago (2014-09-25 02:41:03 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 40665 (presubmit successful).