Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 59693006: Register generic type of instantiated Map literal. (Closed)

Created:
7 years, 1 month ago by karlklose
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Register generic type of instantiated Map literal. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=30041

Patch Set 1 #

Patch Set 2 : Also register rti dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
karlklose
7 years, 1 month ago (2013-11-06 14:32:24 UTC) #1
floitsch
LGTM, but this is not my domain. If you have any doubts, please let somebody ...
7 years, 1 month ago (2013-11-06 20:56:02 UTC) #2
Johnni Winther
lgtm
7 years, 1 month ago (2013-11-07 07:53:30 UTC) #3
karlklose
On 2013/11/07 07:53:30, Johnni Winther wrote: > lgtm PTAL.
7 years, 1 month ago (2013-11-07 11:18:23 UTC) #4
Johnni Winther
lgtm
7 years, 1 month ago (2013-11-07 11:30:35 UTC) #5
karlklose
7 years, 1 month ago (2013-11-07 11:31:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r30041 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698