Rework launch data

Rework launch data

R=jwren@google.com, paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40610

[Brian Wilkerson, 2014-09-23 20:07:20]

brianwilkerson@google.com changed reviewers:
+ jwren@google.com, paulberry@google.com

[Paul Berry, 2014-09-23 20:34:12]

lgtm once the issue below is addressed.

https://codereview.chromium.org/596893002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/domain_execution.dart (right):

https://codereview.chromium.org/596893002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/domain_execution.dart:155: }
Needs an else block that sets kind to ExecutableKind.NOT_EXECUTABLE.

(docs say that kind == null is only used for non-Dart files)

Also, I'm concerned that this wasn't caught by a unit test.  It looks like
perhaps the unit tests only validate the logic in _reportCurrentFileStatus()? 
Maybe we need another unit test to validate the logic in this function.

[jwren, 2014-09-23 20:34:31]

On 2014/09/23 20:07:21, Brian Wilkerson wrote:

LGTM

[Brian Wilkerson, 2014-09-23 22:01:24]

https://codereview.chromium.org/596893002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/domain_execution.dart (right):

https://codereview.chromium.org/596893002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/domain_execution.dart:155: }
> Needs an else block that sets kind to ExecutableKind.NOT_EXECUTABLE.

Good catch! Done.
 
> Also, I'm concerned that this wasn't caught by a unit test.

Yes, we need better tests. My hope is that I can get them written while Keerti
is starting the Editor integration.

[Brian Wilkerson, 2014-09-23 22:02:16]

Committed patchset #2 (id:20001) manually as 40610 (presubmit successful).