Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 596573002: pkg/shelf Include default bodies for 'Not Found' and 'Forbidden' Response (Closed)

Created:
6 years, 3 months ago by kevmoo
Modified:
6 years, 3 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/shelf Include default bodies for 'Not Found' and 'Forbidden' Response Also fixed documentation of Response constructors R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=40607

Patch Set 1 #

Total comments: 4

Patch Set 2 : cl nits #

Patch Set 3 : changelog tweaks and ready for publish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -21 lines) Patch
M pkg/shelf/CHANGELOG.md View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M pkg/shelf/lib/src/response.dart View 1 6 chunks +23 lines, -19 lines 0 comments Download
M pkg/shelf/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
kevmoo
6 years, 3 months ago (2014-09-22 22:51:47 UTC) #2
nweiz
https://codereview.chromium.org/596573002/diff/1/pkg/shelf/lib/src/response.dart File pkg/shelf/lib/src/response.dart (right): https://codereview.chromium.org/596573002/diff/1/pkg/shelf/lib/src/response.dart#newcode148 pkg/shelf/lib/src/response.dart:148: /// [Stream<List<int>>]. This should still include "or `null`". https://codereview.chromium.org/596573002/diff/1/pkg/shelf/lib/src/response.dart#newcode151 ...
6 years, 3 months ago (2014-09-23 00:09:39 UTC) #3
kevmoo
PTAL https://codereview.chromium.org/596573002/diff/1/pkg/shelf/lib/src/response.dart File pkg/shelf/lib/src/response.dart (right): https://codereview.chromium.org/596573002/diff/1/pkg/shelf/lib/src/response.dart#newcode148 pkg/shelf/lib/src/response.dart:148: /// [Stream<List<int>>]. On 2014/09/23 00:09:38, nweiz wrote: > ...
6 years, 3 months ago (2014-09-23 05:00:05 UTC) #4
kevmoo
PTAL
6 years, 3 months ago (2014-09-23 05:00:05 UTC) #5
nweiz
lgtm!
6 years, 3 months ago (2014-09-23 20:22:59 UTC) #6
kevmoo
6 years, 3 months ago (2014-09-23 21:48:38 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 40607 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698