Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 595183003: Always initialize top-level `Isolate` for deferred libraries. (Closed)

Created:
6 years, 2 months ago by sigurdm
Modified:
6 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Always initialize top-level `Isolate` for deferred libraries. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=40763

Patch Set 1 #

Patch Set 2 : Add Tests #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/emitter.dart View 1 2 3 1 chunk +15 lines, -15 lines 0 comments Download
A + tests/language/deferred_only_constant_lib.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
A + tests/language/deferred_only_constant_test.dart View 1 2 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sigurdm
6 years, 2 months ago (2014-09-29 10:16:23 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/595183003/diff/20001/tests/language/deferred_only_constant_test.dart File tests/language/deferred_only_constant_test.dart (right): https://codereview.chromium.org/595183003/diff/20001/tests/language/deferred_only_constant_test.dart#newcode11 tests/language/deferred_only_constant_test.dart:11: print(lib.constant); Expect.equals(...) ?
6 years, 2 months ago (2014-09-29 10:35:59 UTC) #3
sigurdm
https://codereview.chromium.org/595183003/diff/20001/tests/language/deferred_only_constant_test.dart File tests/language/deferred_only_constant_test.dart (right): https://codereview.chromium.org/595183003/diff/20001/tests/language/deferred_only_constant_test.dart#newcode11 tests/language/deferred_only_constant_test.dart:11: print(lib.constant); On 2014/09/29 10:35:59, floitsch wrote: > Expect.equals(...) ? ...
6 years, 2 months ago (2014-09-29 10:39:29 UTC) #4
sigurdm
6 years, 2 months ago (2014-09-29 11:52:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 40763 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698