Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 594843003: Introduce LibraryUpdater. (Closed)

Created:
6 years, 3 months ago by ahe
Modified:
6 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged with r40748. #

Patch Set 3 : Fix whitespace problem. #

Patch Set 4 : Test edge cases. #

Total comments: 4

Patch Set 5 : Address Johnni's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -4 lines) Patch
A dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 2 1 chunk +196 lines, -0 lines 0 comments Download
M dart/site/try/poi/poi.dart View 3 chunks +24 lines, -4 lines 0 comments Download
A dart/tests/try/poi/compiler_test_case.dart View 1 chunk +66 lines, -0 lines 0 comments Download
A dart/tests/try/poi/library_updater_test.dart View 1 2 3 4 1 chunk +124 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
ahe
6 years, 3 months ago (2014-09-23 13:11:52 UTC) #2
ahe
Ping.
6 years, 2 months ago (2014-09-28 12:43:00 UTC) #3
ahe
Added tests of edge cases (empty bodies and arrow functions).
6 years, 2 months ago (2014-09-28 14:15:22 UTC) #4
Johnni Winther
lgtm https://codereview.chromium.org/594843003/diff/60001/dart/tests/try/poi/library_updater_test.dart File dart/tests/try/poi/library_updater_test.dart (right): https://codereview.chromium.org/594843003/diff/60001/dart/tests/try/poi/library_updater_test.dart#newcode69 dart/tests/try/poi/library_updater_test.dart:69: // Only whitespace changes. Can be reused; no ...
6 years, 2 months ago (2014-09-29 09:34:42 UTC) #5
Johnni Winther
https://codereview.chromium.org/594843003/diff/60001/dart/tests/try/poi/library_updater_test.dart File dart/tests/try/poi/library_updater_test.dart (right): https://codereview.chromium.org/594843003/diff/60001/dart/tests/try/poi/library_updater_test.dart#newcode32 dart/tests/try/poi/library_updater_test.dart:32: this.expectedCanReuse, Change these to named arguments.
6 years, 2 months ago (2014-09-29 09:37:58 UTC) #6
ahe
Thanks Johnni and Luke! https://codereview.chromium.org/594843003/diff/60001/dart/tests/try/poi/library_updater_test.dart File dart/tests/try/poi/library_updater_test.dart (right): https://codereview.chromium.org/594843003/diff/60001/dart/tests/try/poi/library_updater_test.dart#newcode32 dart/tests/try/poi/library_updater_test.dart:32: this.expectedCanReuse, On 2014/09/29 09:37:57, Johnni ...
6 years, 2 months ago (2014-09-29 11:44:42 UTC) #7
ahe
6 years, 2 months ago (2014-09-29 12:01:53 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 40764 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698