Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 594503005: 'Convert Getter to Method' refactoring implementation. (Closed)

Created:
6 years, 3 months ago by scheglov
Modified:
6 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

'Convert Getter to Method' refactoring implementation. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=40574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -130 lines) Patch
A + pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart View 5 chunks +37 lines, -55 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A + pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 5 chunks +35 lines, -75 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 3 months ago (2014-09-22 20:55:38 UTC) #1
Brian Wilkerson
LGTM
6 years, 3 months ago (2014-09-22 21:50:29 UTC) #2
scheglov
6 years, 3 months ago (2014-09-22 21:55:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40574 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698