Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 594243003: Fix mac build for XCode v6.0 (Closed)

Created:
6 years, 3 months ago by kevmoo
Modified:
6 years, 3 months ago
Reviewers:
iposva, Ivan Posva
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gyp/find_mac_gcc_version.py View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
kevmoo
I guess there are only a few of us staying on bleeding edge
6 years, 3 months ago (2014-09-23 18:01:02 UTC) #2
Ivan Posva
-Ivan https://codereview.chromium.org/594243003/diff/1/tools/gyp/find_mac_gcc_version.py File tools/gyp/find_mac_gcc_version.py (right): https://codereview.chromium.org/594243003/diff/1/tools/gyp/find_mac_gcc_version.py#newcode30 tools/gyp/find_mac_gcc_version.py:30: return 'com.apple.compilers.llvm.clang.1_0' Have you verified that this is ...
6 years, 3 months ago (2014-09-23 22:58:36 UTC) #4
kevmoo
On 2014/09/23 22:58:36, Ivan Posva wrote: > -Ivan > > https://codereview.chromium.org/594243003/diff/1/tools/gyp/find_mac_gcc_version.py > File tools/gyp/find_mac_gcc_version.py (right): ...
6 years, 3 months ago (2014-09-23 23:24:36 UTC) #5
Ivan Posva
LGTM -ip
6 years, 3 months ago (2014-09-23 23:25:31 UTC) #6
kevmoo
6 years, 3 months ago (2014-09-23 23:27:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 40616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698