Issue 594183003: Mark _Bigint._mulAdd and conversion methods in typed_data as invisible. Strengthen the mirror invoc…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 594183003: Mark _Bigint._mulAdd and conversion methods in typed_data as invisible. Strengthen the mirror invoc… (Closed)

Created:
6 years, 3 months ago by rmacnak

Modified:
6 years, 3 months ago

Reviewers:
regis, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Mark _Bigint._mulAdd and conversion methods in typed_data as invisible. Strengthen the mirror invocation fuzzer. BUG=http://dartbug.com/21046 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=40609

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -16 lines)			Patch
M	runtime/vm/object.cc	View	2 chunks	+36 lines, -7 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/lib/mirrors/invocation_fuzz_test.dart	View	6 chunks	+28 lines, -9 lines	0 comments	Download

Total messages: 5 (1 generated)

rmacnak

On 2014/09/23 17:57:12, regis wrote: > LGTM, but what was wrong with the previous attempt? ...

6 years, 3 months ago (2014-09-23 18:14:31 UTC) #4

rmacnak

6 years, 3 months ago (2014-09-23 22:01:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 40609 (presubmit successful).